kotlin: drop resolutionStrategy.eachPlugin block#179
Merged
Conversation
Now that the Monaco Azure Artifacts Maven feed mirrors Maven Central upstream (including plugin marker POMs), Gradle's default plugin resolution should work without the eachPlugin remap that was added in PR #176. If this test passes both GHA and the ADO publish pipeline, we can land it permanently and close out PR #177 + delete the stale hotfix branches.
pwang347
approved these changes
May 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Removes the
pluginManagement.resolutionStrategy.eachPluginblock fromclients/kotlin/settings.gradle.kts. Net −17 lines.Why it's no longer needed
PR #176 added the block on a wrong hypothesis (that the ESRP build env's Maven mirror was missing the tiny
<plugin-id>.gradle.pluginmarker POMs). The real cause was 1ES Network Isolation silently blocking the public Maven Central / Gradle Plugin Portal entirely. That root cause is now fixed in thevscode-engineeringmaven-package template via a newcustomMavenRegistryparameter + Gradle init script that routes resolution through the Monaco Azure Artifacts Maven feed (which mirrors Maven Central upstream, including plugin marker POMs).Validation
Follow-ups
hotfix/kotlin-plugin-resolution,hotfix/kotlin-serialization-plugin,test/kotlin-pin-2.1.20, and this oneref: connor4312/maven-pipelineinclients/kotlin/pipeline.ymlto the stable ref once the vscode-engineering template change lands