Skip to content

kotlin: drop resolutionStrategy.eachPlugin block#179

Merged
connor4312 merged 1 commit into
mainfrom
test/kotlin-remove-each-plugin
May 29, 2026
Merged

kotlin: drop resolutionStrategy.eachPlugin block#179
connor4312 merged 1 commit into
mainfrom
test/kotlin-remove-each-plugin

Conversation

@connor4312

Copy link
Copy Markdown
Member

Summary

Removes the pluginManagement.resolutionStrategy.eachPlugin block from clients/kotlin/settings.gradle.kts. Net −17 lines.

Why it's no longer needed

PR #176 added the block on a wrong hypothesis (that the ESRP build env's Maven mirror was missing the tiny <plugin-id>.gradle.plugin marker POMs). The real cause was 1ES Network Isolation silently blocking the public Maven Central / Gradle Plugin Portal entirely. That root cause is now fixed in the vscode-engineering maven-package template via a new customMavenRegistry parameter + Gradle init script that routes resolution through the Monaco Azure Artifacts Maven feed (which mirrors Maven Central upstream, including plugin marker POMs).

Validation

  • GHA Kotlin CI ✅
  • Manual ADO publish-pipeline dry-run (publish unticked) ✅

Follow-ups

  • Close kotlin: route serialization plugin to its own maven artifact #177 (the fixup PR that patched a bug in the eachPlugin mapping — now irrelevant since the whole block is gone)
  • Delete stale branches hotfix/kotlin-plugin-resolution, hotfix/kotlin-serialization-plugin, test/kotlin-pin-2.1.20, and this one
  • Bump ref: connor4312/maven-pipeline in clients/kotlin/pipeline.yml to the stable ref once the vscode-engineering template change lands

Now that the Monaco Azure Artifacts Maven feed mirrors Maven Central upstream (including plugin marker POMs), Gradle's default plugin resolution should work without the eachPlugin remap that was added in PR #176. If this test passes both GHA and the ADO publish pipeline, we can land it permanently and close out PR #177 + delete the stale hotfix branches.
@connor4312 connor4312 merged commit b76efe1 into main May 29, 2026
12 checks passed
@connor4312 connor4312 deleted the test/kotlin-remove-each-plugin branch May 29, 2026 18:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants